New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): clear prev style with string and object #10313

Closed

FireBushtree wants to merge 1 commit into vuejs:main from FireBushtree:fix/patch-style

FireBushtree commented Feb 11, 2024

use this code, after click button, the text style will change to 'font-size: 12px'

<script setup>
import { ref } from 'vue'

const style = ref({ color: 'red' })
function handleClick() {
  style.value = { fontSize: '12px' }
}
</script>

<template>
  <h1 :style="style">Hello World</h1>
  <button @click="handleClick">change style</button>
</template>

but this code, after click button, the text style will change to 'color: red; font-size: 12px'. the 'color: red' do not be removed

<script setup>
import { ref } from 'vue'

const style = ref('color: red')
function handleClick() {
  style.value = { fontSize: '12px' }
}
</script>

<template>
  <h1 :style="style">Hello World</h1>
  <button @click="handleClick">change style</button>
</template>


          fix(runtime-dom): clear prev style with string and object

d07fe6e

FireBushtree mentioned this pull request

style is not cleared #10352

Closed

Doctor-wu mentioned this pull request

fix: should clear previous css string value #10373

Merged

Member

yyx990803 commented Feb 25, 2024

Thanks for the PR - however I think #10373 is a cleaner fix as it avoids allocating a temporary object (we only need the keys).

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet